Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[People Picker] change titleText to non-required property #184

Merged
merged 2 commits into from
Dec 7, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/documentation/docs/controls/PeoplePicker.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ The People picker control can be configured with the following properties:
| Property | Type | Required | Description | Default |
| ---- | ---- | ---- | ---- | ---- |
| context | WebPartContext | yes | Context of the current web part. | |
| titleText | string | yes | Text to be displayed on the control | |
| titleText | string | no | Text to be displayed on the control | |
| groupName | string | no | group from which users are fetched. Leave it blank if need to filter all users | _none_ |
| personSelectionLimit | number | no | Defines the limit of people that can be selected in the control | |
| isRequired | boolean | no | Set if the control is required or not | false |
Expand Down
2 changes: 1 addition & 1 deletion src/controls/peoplepicker/IPeoplePicker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export interface IPeoplePickerProps {
/**
* Text of the Control
*/
titleText: string;
titleText?: string;
/**
* Web Absolute Url of source site
*/
Expand Down
2 changes: 1 addition & 1 deletion src/controls/peoplepicker/PeoplePickerComponent.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,7 @@ export class PeoplePicker extends React.Component<IPeoplePickerProps, IPeoplePic

const peoplepicker = (
<div id="people" className={`${styles.defaultClass} ${this.props.peoplePickerWPclassName ? this.props.peoplePickerWPclassName : ''}`}>
<Label>{this.props.titleText || strings.peoplePickerComponentTitleText}</Label>
{this.props.titleText && <Label>{this.props.titleText}</Label>}

<NormalPeoplePicker pickerSuggestionsProps={suggestionProps}
onResolveSuggestions={this._onPersonFilterChanged}
Expand Down
1 change: 0 additions & 1 deletion src/loc/de-de.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ define([], () => {

peoplePickerComponentTooltipMessage: "People Picker",
peoplePickerComponentErrorMessage: "Benutzerauswahl ist ein Pflichtfeld",
peoplePickerComponentTitleText: "Benutzer auswählen",
peoplePickerSuggestionsHeaderText: 'Vorgeschlagene Benutzer',
peoplePickerLoadingText: 'Laden',

Expand Down
1 change: 0 additions & 1 deletion src/loc/en-us.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ define([], () => {

peoplePickerComponentTooltipMessage: "People Picker",
peoplePickerComponentErrorMessage: "Required Field",
peoplePickerComponentTitleText: "Pick the user(s)",
peoplePickerSuggestionsHeaderText: 'Suggested People',
peoplePickerLoadingText: 'Loading',

Expand Down
1 change: 0 additions & 1 deletion src/loc/fr-fr.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ define([], () => {

peoplePickerComponentTooltipMessage: "Sélecteur de personnes",
peoplePickerComponentErrorMessage: "Le sélecteur de personnes est obligatoire",
peoplePickerComponentTitleText: "Choisissez l'utilisateur(s)",
peoplePickerSuggestionsHeaderText: 'Personnes suggérées',
peoplePickerLoadingText: 'Chargement',

Expand Down
1 change: 0 additions & 1 deletion src/loc/mystrings.d.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
declare interface IControlStrings {
peoplePickerComponentTooltipMessage: string;
peoplePickerComponentErrorMessage: string;
peoplePickerComponentTitleText: string;
peoplePickerSuggestionsHeaderText: string;
genericNoResultsFoundText: string;
peoplePickerLoadingText: string;
Expand Down
1 change: 0 additions & 1 deletion src/loc/nl-nl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ define([], () => {

peoplePickerComponentTooltipMessage: "Personen kiezen",
peoplePickerComponentErrorMessage: "Verplicht veld",
peoplePickerComponentTitleText: "Kies personen",
peoplePickerSuggestionsHeaderText: 'Voorgestelde personen',
peoplePickerLoadingText: 'Laden',

Expand Down