[People Picker] change titleText to non-requied property

pnp · Nov 16, 2018 · 28346f4 · 28346f4
1 parent c198454
commit 28346f4
Show file tree

Hide file tree

Showing 8 changed files with 3 additions and 8 deletions.
diff --git a/docs/documentation/docs/controls/PeoplePicker.md b/docs/documentation/docs/controls/PeoplePicker.md
@@ -55,7 +55,7 @@ The People picker control can be configured with the following properties:
 | Property | Type | Required | Description | Default |
 | ---- | ---- | ---- | ---- | ---- |
 | context | WebPartContext | yes | Context of the current web part. | |
-| titleText | string | yes | Text to be displayed on the control | |
+| titleText | string | no | Text to be displayed on the control | |
 | groupName | string | no | group from which users are fetched. Leave it blank if need to filter all users | _none_ |
 | personSelectionLimit | number | no | Defines the limit of people that can be selected in the control | |
 | isRequired | boolean | no | Set if the control is required or not | false |

diff --git a/src/controls/peoplepicker/IPeoplePicker.ts b/src/controls/peoplepicker/IPeoplePicker.ts
@@ -15,7 +15,7 @@ export interface IPeoplePickerProps {
   /**
    * Text of the Control
   */
-  titleText: string;
+  titleText?: string;
   /**
    * Web Absolute Url of source site
    */

diff --git a/src/controls/peoplepicker/PeoplePickerComponent.tsx b/src/controls/peoplepicker/PeoplePickerComponent.tsx
@@ -407,7 +407,7 @@ export class PeoplePicker extends React.Component<IPeoplePickerProps, IPeoplePic
 
     const peoplepicker = (
       <div id="people" className={`${styles.defaultClass} ${this.props.peoplePickerWPclassName ? this.props.peoplePickerWPclassName : ''}`}>
-        <Label>{this.props.titleText || strings.peoplePickerComponentTitleText}</Label>
+        {this.props.titleText && <Label>{this.props.titleText}</Label>}
 
         <NormalPeoplePicker pickerSuggestionsProps={suggestionProps}
           onResolveSuggestions={this._onPersonFilterChanged}

diff --git a/src/loc/de-de.ts b/src/loc/de-de.ts
@@ -48,7 +48,6 @@ define([], () => {
 
     peoplePickerComponentTooltipMessage: "People Picker",
     peoplePickerComponentErrorMessage: "Benutzerauswahl ist ein Pflichtfeld",
-    peoplePickerComponentTitleText: "Benutzer auswählen",
     peoplePickerSuggestionsHeaderText: 'Vorgeschlagene Benutzer',
     peoplePickerLoadingText: 'Laden',
 

diff --git a/src/loc/en-us.ts b/src/loc/en-us.ts
@@ -48,7 +48,6 @@ define([], () => {
 
     peoplePickerComponentTooltipMessage: "People Picker",
     peoplePickerComponentErrorMessage: "Required Field",
-    peoplePickerComponentTitleText: "Pick the user(s)",
     peoplePickerSuggestionsHeaderText: 'Suggested People',
     peoplePickerLoadingText: 'Loading',
 

diff --git a/src/loc/fr-fr.ts b/src/loc/fr-fr.ts
@@ -48,7 +48,6 @@ define([], () => {
 
     peoplePickerComponentTooltipMessage: "Sélecteur de personnes",
     peoplePickerComponentErrorMessage: "Le sélecteur de personnes est obligatoire",
-    peoplePickerComponentTitleText: "Choisissez l'utilisateur(s)",
     peoplePickerSuggestionsHeaderText: 'Personnes suggérées',
     peoplePickerLoadingText: 'Chargement',
 

diff --git a/src/loc/mystrings.d.ts b/src/loc/mystrings.d.ts
@@ -1,7 +1,6 @@
 declare interface IControlStrings {
   peoplePickerComponentTooltipMessage: string;
   peoplePickerComponentErrorMessage: string;
-  peoplePickerComponentTitleText: string;
   peoplePickerSuggestionsHeaderText: string;
   genericNoResultsFoundText: string;
   peoplePickerLoadingText: string;

diff --git a/src/loc/nl-nl.ts b/src/loc/nl-nl.ts
@@ -48,7 +48,6 @@ define([], () => {
 
     peoplePickerComponentTooltipMessage: "Personen kiezen",
     peoplePickerComponentErrorMessage: "Verplicht veld",
-    peoplePickerComponentTitleText: "Kies personen",
     peoplePickerSuggestionsHeaderText: 'Voorgestelde personen',
     peoplePickerLoadingText: 'Laden',