Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solving BiDi Issue with Incognito Mode #1836

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

Abdelrhman-Ellithy
Copy link
Contributor

this commit solves an issue when creating a Local Driver in Incognito Mode.

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.42%. Comparing base (51d9563) to head (cec46c8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../driver/internal/DriverFactory/OptionsManager.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1836      +/-   ##
============================================
- Coverage     53.89%   52.42%   -1.47%     
+ Complexity     1401     1355      -46     
============================================
  Files           115      115              
  Lines         10359    10361       +2     
  Branches       1000     1000              
============================================
- Hits           5583     5432     -151     
- Misses         4133     4289     +156     
+ Partials        643      640       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MahmoudElSharkawy MahmoudElSharkawy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Abdelrhman-Ellithy for your valuable contribution; We are looking forward to more contributions from your side isA!

@MahmoudElSharkawy MahmoudElSharkawy merged commit 365d907 into ShaftHQ:main Jan 6, 2025
16 of 18 checks passed
@Abdelrhman-Ellithy
Copy link
Contributor Author

Thanks @Abdelrhman-Ellithy for your valuable contribution; We are looking forward to more contributions from your side isA!

I appreciate your words @MahmoudElSharkawy , It's a pleasure for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants