Add app name to pods/services names #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, the user has to filter based on labels to see which pods are from which app. This PR adds the app name to the names of the pods and services. While the names will become slightly longer, it makes it easier for users to see which resources are from each app w/o filtering based on labels. Also, this is consistent with what we do in the GKE deployer, where the app name is also part of the resource names.
rgrandl
requested review from
mwhittaker and
spetrovic77
and removed request for
mwhittaker
spetrovic77
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the user has to filter based on labels to see which pods are from which app.
This PR adds the app name to the names of the pods and services. While the names will become slightly longer, it makes it easier for users to see which resources are from each app w/o filtering based on labels. Also, this is consistent with what we do in the GKE deployer, where the app name is also part of the resource names.