Skip to content

Commit

Permalink
Add app name to pods/services names (#113)
Browse files Browse the repository at this point in the history
Right now, the user has to filter based on labels to see which pods are
from which app.

This PR adds the app name to the names of the pods and services.
While the names will become slightly longer, it makes it easier for
users to see which resources are from each app w/o filtering based on
labels. Also, this is consistent with what we do in the GKE deployer, where
the app name is also part of the resource names.
  • Loading branch information
rgrandl authored Jul 10, 2024
1 parent ab31334 commit 0f8a8e4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion internal/impl/kube.go
Original file line number Diff line number Diff line change
Expand Up @@ -866,5 +866,5 @@ func shortenComponent(component string) string {
func deploymentName(app, component, deploymentId string) string {
hash := hash8([]string{app, component, deploymentId})
shortened := strings.ToLower(shortenComponent(component))
return fmt.Sprintf("%s-%s-%s", shortened, deploymentId[:8], hash)
return fmt.Sprintf("%s-%s-%s-%s", app, shortened, deploymentId[:8], hash)
}

0 comments on commit 0f8a8e4

Please sign in to comment.