Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3790: Deprecation of passport-saml #3799

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Fixes #3790: Deprecation of passport-saml #3799

merged 1 commit into from
Feb 1, 2023

Conversation

manekenpix
Copy link
Member

Issue This PR Addresses

Fixes #3790

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

This PR removes the deprecated passport-saml in favour of @node-saml/passport-saml.

Steps to test the PR

  • Run telescope
  • Assert that sign up and sign in work as expected

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@manekenpix manekenpix added area: sso Authentication dependencies Pull requests that update a dependency file labels Feb 1, 2023
@manekenpix manekenpix requested review from humphd and a team February 1, 2023 21:51
@manekenpix manekenpix self-assigned this Feb 1, 2023
@manekenpix manekenpix removed the request for review from humphd February 1, 2023 21:51
sfrunza13
sfrunza13 approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@sfrunza13 sfrunza13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell this looks to be good :)

@manekenpix manekenpix merged commit e5c690b into Seneca-CDOT:master Feb 1, 2023
@manekenpix manekenpix deleted the node-saml/passport-saml branch February 1, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfrunza13 sfrunza13 sfrunza13 approved these changes

Assignees

@manekenpix manekenpix

Labels
area: sso Authentication dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecation of passport-saml
2 participants
@manekenpix @sfrunza13