chore: switch from passport-saml to node-saml/passport-saml (#3799)

Seneca-CDOT · Feb 1, 2023 · e5c690b · e5c690b
1 parent 4e73c62
commit e5c690b
Show file tree

Hide file tree

Showing 3 changed files with 104 additions and 30 deletions.
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/api/sso/package.json b/src/api/sso/package.json
@@ -4,7 +4,7 @@
   "version": "1.0.0",
   "description": "An SSO Authentication and Authorization Service",
   "scripts": {
-    "dev": "env-cmd -f env.local nodemon src/server.js",
+    "dev": "env-cmd -f .env nodemon src/server.js",
     "start": "node src/server.js",
     "eslint": "eslint --config .eslintrc.js \"./**/*.js\"",
     "eslint-time": "TIMING=1 eslint --config .eslintrc.js \"./**/*.js\"",
@@ -21,6 +21,7 @@
   },
   "homepage": "https://github.com/Seneca-CDOT/telescope#readme",
   "dependencies": {
+    "@node-saml/passport-saml": "4.0.2",
     "@senecacdot/satellite": "^1.29.0",
     "@slack/bolt": "3.12.2",
     "@supabase/supabase-js": "1.29.4",
@@ -30,8 +31,7 @@
     "jsonwebtoken": "9.0.0",
     "minimatch": "3.0.5",
     "normalize-url": "6.1.0",
-    "passport": "0.5.2",
-    "passport-saml": "3.2.4"
+    "passport": "0.5.2"
   },
   "engines": {
     "node": ">=16"

diff --git a/src/api/sso/src/authentication.js b/src/api/sso/src/authentication.js
@@ -4,7 +4,7 @@
  * https://blog.humphd.org/not-so-simple-saml/
  */
 const passport = require('passport');
-const SamlStrategy = require('passport-saml').Strategy;
+const SamlStrategy = require('@node-saml/passport-saml').Strategy;
 const { logger, hash } = require('@senecacdot/satellite');
 
 const supabase = require('./supabase');