Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clarification to differentiate between the blog URL and the RSS(feed URL) during sign-up #3763

Merged
merged 1 commit into from
Nov 25, 2022
Merged

Add clarification to differentiate between the blog URL and the RSS(feed URL) during sign-up #3763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/web/app/src/components/SignUp/Forms/BlogFeeds.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,11 @@ const BlogFeeds = () => {
return (
<RSSFeeds
title="Blog and RSS"
prompt="Enter your blog URL and select the RSS you want to use in Telescope"
prompt="Enter your blog root URL (HTML) and select the blog's RSS feed URL (XML) you want to use in Telescope, such as:"
promptExamples={[
'Blog root URL: https://dev.to/user',
'RSS feed URL: https://dev.to/feed/user',
]}
buttonText="Validate"
helperText="Validate your Blog URL"
noFeedsSelected="Please validate your blog URL"
Expand Down
16 changes: 14 additions & 2 deletions src/web/app/src/components/SignUp/Forms/RSSFeeds.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,10 @@ const useStyles = makeStyles((theme: Theme) =>
height: '10px',
color: '#474747',
},
helpTextExample: {
fontSize: '.9em',
fontWeight: 'normal',
},
})
);

Expand All @@ -144,7 +148,8 @@ type RSSFeedsFormProps = {
selected: 'blogs' | 'channels';
discovered: 'allBlogs' | 'allChannels';
};
prompt: string;
prompt?: string;
promptExamples?: Array<string>;
title: string;
buttonText: string;
helperText: string;
Expand All @@ -163,6 +168,7 @@ const RSSFeeds = connect<RSSFeedsFormProps, SignUpForm>(
({
feeds: { selected, discovered },
prompt,
promptExamples,
title,
buttonText,
helperText,
Expand Down Expand Up @@ -247,7 +253,13 @@ const RSSFeeds = connect<RSSFeedsFormProps, SignUpForm>(
<div className={classes.root}>
<div className={classes.container}>
<h1 className={classes.blogPageTitle}>{title}</h1>
<h2 className={classes.helpText}>{prompt}</h2>
<h2 className={classes.helpText}>
{prompt}
{promptExamples?.map((example) => (
<div className={classes.helpTextExample}>{example}</div>
))}
</h2>

<div className={classes.infoContainer}>
<div className={classes.inputsContainer}>
<TextInput
Expand Down