-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clarification to differentiate between the blog URL and the RSS(feed URL) during sign-up #3763
Conversation
I think it might be nice to provide an example of a blog URL, so users who don't know what HTML and XML are know what to provide. |
Maybe, but there are many different sites, so I'm not sure it's practical to list them all or useful to list only one. |
I think maybe one example would be fine, I think most people use dev.to. But just a simple example, something like: Blog URL: https://dev.to/user |
Agree with @NeilAn99, let's add examples of blog url and feed url in 2 separate lines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cychu42 Your implementation looks good!
I have left some initial review that we could address
@@ -8,6 +8,8 @@ const ChannelFeeds = () => { | |||
<RSSFeeds | |||
title="YouTube and Twitch" | |||
prompt="OPTIONAL: Enter your YouTube and/or Twitch channel" | |||
promptExample1="" | |||
promptExample2="" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making the prop optional and assigning a default value like empty list, will ensure that nothing will break and would not have to make changes here.
@batunpc Good ideas! I made some changes accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @cychu42 , great job 👍
Thank you all for the reviews. I just rebased and squashed the commits, after the approval. |
Last minute suggestion: The text looks a bit bloated and hard to read, what about something more simple? maybe a basic but clear indication of what valid and non valid blog URLs are: It doesn't have to be exactly this ^, but maybe something a bit cleaner would be better for users? It could also include links to blog URL vs feed URL explanations or definitions, or Blog vs Post (some people think a post is a blog). I'm also ok if the team decides that the changes proposed in this PR are the way to go. |
What if we use some shorter text instead:
The 2 examples can be smaller texts like you suggested. |
@cychu42 Yeah, I think that'd work. |
* Turn examples into an array * Fix Eslint error * Shorten the prompt and resize URLs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Issue This PR Addresses
USAGE: #3646
This PR addresses one of the issues raised in the issue.
Type of Change
Description
The issue was that some users experience confusion between a blog URL (blog's root HTML) and select the RSS (blog's feed XML) during sign-up. This PR adds 2 sentences to the prompt to clarify the difference, in
src\web\app\src\components\SignUp\Forms\BlogFeeds.tsx
.Steps to test the PR
Test this by going through the sign-up process to view the Blog Feeds page.
During testing, you can use test account
user1
with passworduser1pass
.You can enter any Github account name to get through the page before this page.
Checklist