Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2868 Remove MDX from our Next.js frontend #3015

Merged
merged 3 commits into from
Feb 21, 2022
Merged

Fixes #2868 Remove MDX from our Next.js frontend #3015

merged 3 commits into from
Feb 21, 2022

Conversation

cindyorangis
Copy link
Contributor

Issue This PR Addresses

Fixes #2868

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

This PR removes the MDX-related code from Next.js frontend and recreates the About page as React components.

Steps to test the PR

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@cindyorangis cindyorangis added the area: nextjs Nextjs related issues label Feb 20, 2022
@cindyorangis cindyorangis added this to the 2.8 Release milestone Feb 20, 2022
@cindyorangis cindyorangis self-assigned this Feb 20, 2022
@gitpod-io
Copy link

gitpod-io bot commented Feb 20, 2022

@cindyorangis cindyorangis added area: css styling Anything related to CSS styling area: front-end labels Feb 20, 2022
humphd
humphd previously approved these changes Feb 21, 2022
View reviewed changes
manekenpix
manekenpix previously approved these changes Feb 21, 2022
View reviewed changes
@humphd
Copy link
Contributor

humphd commented Feb 21, 2022

We need an update and rebase on this.

@cindyorangis cindyorangis dismissed stale reviews from manekenpix and humphd via dc1e433 February 21, 2022 16:05
@cindyorangis cindyorangis merged commit 1b7ae4c into Seneca-CDOT:master Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manekenpix manekenpix manekenpix approved these changes

@humphd humphd humphd approved these changes

Assignees

@cindyorangis cindyorangis

Labels
area: css styling Anything related to CSS styling area: front-end area: nextjs Nextjs related issues
Projects
None yet
Milestone
2.8 Release
Development

Successfully merging this pull request may close these issues.

Remove MDX-related stuff from our Next.js Telescope frontend
3 participants
@cindyorangis @humphd @manekenpix