Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MDX-related stuff from our Next.js Telescope frontend #2868

Closed
cindyorangis opened this issue Feb 9, 2022 · 3 comments · Fixed by #3015
Closed

Remove MDX-related stuff from our Next.js Telescope frontend #2868

cindyorangis opened this issue Feb 9, 2022 · 3 comments · Fixed by #3015
Assignees
Labels
area: front-end area: nextjs Nextjs related issues type: documentation (docs) Improvements or additions to documentation type: enhancement New feature or request
Milestone

Comments

@cindyorangis
Copy link
Contributor

Now that we have a Docusaurus website to hold our docs #2853, we should remove or migrate what we can from Next.js to Docusaurus. Specifically

Changes needed for src/web/package.json:

Changes needed for src/web/next.config.js:

I might have missed something so please check previous PRs and git blame to see where/when the mdx stuff was added

@cindyorangis cindyorangis added the type: enhancement New feature or request label Feb 9, 2022
@Kevan-Y Kevan-Y added the area: docusaurus Anything related to Docusaurus label Feb 9, 2022
@cindyorangis cindyorangis added the type: documentation (docs) Improvements or additions to documentation label Feb 9, 2022
@menghif
Copy link
Contributor

menghif commented Feb 17, 2022

After today's meeting we decided to translate the About page in multiple languages #2962. We also decided to keep the About page on the Telescope app and to remove MDX.

This issue can be converted into removing MDX.

@cindyorangis
Copy link
Contributor Author

I will morph this issue into removing MDX but as a Telescope Historian and because I implemented the About Page in Gatsby.js and @chrispinkney ported it to Next.js (can't believe we're ripping out more of his code), I'd like to point out that the About Page here is almost identical to the Overview doc. This is because we never clearly defined "About Us" so I used the Overview doc as text to render when I was implementing the About Page feature. This is a great opportunity for everyone planning to be involved in #2962 to create an "About Us" page that is meaningful to you all.

@cindyorangis cindyorangis changed the title Migrate the About Page and MDX-related stuff from our Next.js Telescope frontend to Docusaurus Remove MDX-related stuff from our Next.js Telescope frontend Feb 18, 2022
@cindyorangis cindyorangis self-assigned this Feb 18, 2022
@cindyorangis
Copy link
Contributor Author

I will also assign myself this issue since this needs some delicate surgery done and I think I know it well enough... maybe fingerscrossed

@cindyorangis cindyorangis added area: front-end area: nextjs Nextjs related issues and removed area: docusaurus Anything related to Docusaurus labels Feb 18, 2022
@cindyorangis cindyorangis added this to the 2.8 Release milestone Feb 20, 2022
cindyorangis added a commit that referenced this issue Feb 21, 2022
* recreated About page in tsx

* removed mdx from next.js frontend project

* remove next/mdx package and webpack.config.js for next.js frontend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: front-end area: nextjs Nextjs related issues type: documentation (docs) Improvements or additions to documentation type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants