increase max_pull_requests to 250

[RC-Lee]

Issue This PR Addresses

Fixes #2645

Type of Change

• Bugfix: Change which fixes an issue
• New Feature: Change which adds functionality
• Documentation Update: Change which improves documentation
• UI: Change which improves UI

Description

According to the build logs for Release 2.4.0, 220 merged PRs were accounted for.
The easiest fix is to increase the max_pull_requests option in the release-changelog-builder-config.json

However, I have been trying, but have failed, to understand how it got to 220 merged PRs.
Trying to query merged PRs during the time frame provided by the log only comes up with 80 PRs

Querying for all closed PRs, not just merged, during this time frame comes up with 113 PRs.

Similar discrepancies are also in the Release 2.3.0 log where 152 merged PRs were accounted for. But querying on GitHub, there is only 48 merged PRs, and 60 closed.

I couldn't load logs for earlier releases to check.

I suspect, but am unsure if PRs from the merged forked repositories are being accounted for.

Checklist

• Quality: This PR builds and passes our npm test and works locally
• Tests: This PR includes thorough tests or an explanation of why it does not
• Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
• Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

[gitpod-io]

[DukeManh]

Based on this comment, they currently don't have a good way to get the correct number of PRs between two tags. I think this issue will come back once the number of PRs passes 250.

[humphd]

Yeah, there's no great option here. What would you like to see this set at?

[DukeManh]

I'm ok with 250 and ignore the warning in the future.