A bunch of unexpected behaviour #605
Comments
|
Hi there @darrellwarde Thank you for the report. I'll have a look at this. Was this the current specification in your github actions? neo4j/graphql@5020318#diff-d44dd879a02a07f5781424a643498042e49b0b3d49d2682d176d7322e89f69a6R384-R391 |
Apologies, I should have given you that as well to start with! That's from a different workflow file, but identical YAML, the actual block is https://github.com/neo4j/graphql/blob/master/.github/workflows/release.yml#L518-L525 Thanks for the speedy response! |
|
Thank you @darrellwarde For the second question you asked, regarding having a different And branches which ended up in the Given the date range the action fetches the PRs which were merged within the range: Which will then be filtered out depending if they were part of the release. Based on the last time we checked there hasn't been a better API on GitHub yet which would deliver only PRs which were merged between 2 tags. Hope that answers the second question. Looking now in your other question |
|
Oh one thing I saw based on your mono repo setup. The action offers the ability to pre-filter tags or transform tags if they are prefixed like in your case. So you can still use real This was showcased for example: And maybe also helpful. It's possible to checkout this repo and run parts of the action locally. So you don't have to test it within the repo. This even comes with debugging support: I am currently using this branch: https://github.com/mikepenz/release-changelog-builder-action/tree/feature/605_test npm test -- neo4j.test.tsFor the local action to run you need to give it a token so the gitHub API can be called |
|
Do you possibly have an example of which PR ended up in the wrong category? Based on the below output it seems to at least make sense |
|
Strange, our real output was very different! Luckily we haven't fixed the changelog yet, but it ended up like https://github.com/neo4j/graphql/releases/tag/%40neo4j%2Fgraphql%402.5.0 You can see that almost every, if not every, PR is in each category. Just in case we edit it shortly## 🚀 Features
🐛 Fixes
🧪 Tests
|
|
@darrellwarde oh, I should have looked at that earlier. It looks you are using the https://github.com/neo4j/graphql/blob/master/.github/workflows/release.yml#L520 If you want to use v1, this was the latest v1 README and state for the action:
If you would like to use the newer flags please update to You may want to even use more specific versions like specifying And as usual the security warning: If you want to be super careful only use the |
|
Well now I feel like an absolute numpty! Thank you for spotting that, you've probably saved me hours of scratching my head over this. |
|
No worries :D I didn't look at it directly either. Just edited my message above with some additional details. But yeah if you want to try and modify the action and configurations, it's much faster and easier if you run it locally :). So you can pre-test things without needing to tag on the repo, and wait until things run through. |
|
This was really great support, thank you! Pulled down that branch you pointed me to and used it to generate the correct changelogs to copy and paste in, saved me a load of time! Now bumped the version to |
|
@darrellwarde you are very welcome. Happy to be able to help :). Also really nice actions setup you have there. If there's anything we can do to improve the action, or clarify things, .. let me know. Have a great day! |
|
Thanks for the kind words, you have a great day too! |
Sorry for the not very specific title, but having a few issues!
Firstly, the
exhaustivesetting does not appear to be working as expected. Despite having this enabled for each category (features, fixes, tests) on a category label plus a product label, features are appearing in the fixes list, etc.Secondly, date ranges between tags don't seem to be resolving properly. Despite finding the right tag range (
@neo4j/[email protected]...@neo4j/[email protected]), the date range that it infers from that (2021-11-01T10:03:42.000Z to 2021-12-01T13:39:00.000Z), as the previous tag was made 22 days ago, so just over a week over what it's some up with as the start date.Any ideas on the above? Thanks for any help!
Full log below:
Configuration below:
{ "categories": [ { "title": "## 🚀 Features", "labels": ["feature", "graphql"], "exhaustive": true }, { "title": "## 🐛 Fixes", "labels": ["fix", "graphql"], "exhaustive": true }, { "title": "## 🧪 Tests", "labels": ["test", "graphql"], "exhaustive": true } ], "tag_resolver": { "method": "sort" } }The text was updated successfully, but these errors were encountered: