Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format numbers with decimal separator in dashboard #2654

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

JerryHue
Copy link
Contributor

Issue This PR Addresses

Fixes #2616.

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Apply formatting to numbers to the dashboard. The formatting is a decimal separator for all the numbers that may require one.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR does not add tests as it changes the UI.
  • Screenshots: This PR includes screenshots.

image

  • Documentation: This PR does not add new features that require documentation.

@gitpod-io
Copy link

gitpod-io bot commented Jan 14, 2022

humphd
humphd previously approved these changes Jan 14, 2022
manekenpix
manekenpix previously approved these changes Jan 14, 2022
@manekenpix manekenpix added this to the 2.5 Release milestone Jan 14, 2022
@manekenpix manekenpix added the area: dashboard Related to Telescope's dashboard (the page that has stats) label Jan 14, 2022
@humphd
Copy link
Contributor

humphd commented Jan 14, 2022

@JerryHue merge when ready!

@JerryHue JerryHue merged commit 147f4fb into Seneca-CDOT:master Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dashboard Related to Telescope's dashboard (the page that has stats)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Format all numbers in dashboard using commas where necessary
4 participants