Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format all numbers in dashboard using commas where necessary #2616

Closed
humphd opened this issue Dec 15, 2021 · 1 comment · Fixed by #2654
Closed

Format all numbers in dashboard using commas where necessary #2616

humphd opened this issue Dec 15, 2021 · 1 comment · Fixed by #2654
Assignees
@JerryHue
Labels
area: dashboard Related to Telescope's dashboard (the page that has stats) type: enhancement New feature or request
Milestone
2.5 Release

Comments

@humphd
Copy link
Contributor

humphd commented Dec 15, 2021

Some of the numbers we show aren't being formatted with commas:

Screen Shot 2021-12-15 at 5 52 03 PM

4097 vs. 4,097. We can easily do this with https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/NumberFormat.
@humphd humphd added type: enhancement New feature or request area: dashboard Related to Telescope's dashboard (the page that has stats) labels Dec 15, 2021
@JerryHue
Copy link
Contributor

I would like to work on this one!

@JerryHue JerryHue self-assigned this Jan 14, 2022
@JerryHue JerryHue mentioned this issue Jan 14, 2022
Merged
8 tasks
@manekenpix manekenpix added this to the 2.5 Release milestone Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JerryHue JerryHue

Labels
area: dashboard Related to Telescope's dashboard (the page that has stats) type: enhancement New feature or request
Projects
None yet
Milestone
2.5 Release
Development

Successfully merging a pull request may close this issue.

Format numbers with decimal separator in dashboard JerryHue/telescope
3 participants
@humphd @manekenpix @JerryHue