-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show videos in the main timeline #2596
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very cool. One other thing I'd like to see, either here or in follow-up, is to make links into HTML <a>
elements, so they are clickable. I can't remember the subset of HTML that YouTube lets you put in the description, but it's pretty small, and we could likely write a simple parser for it.
8750d25
to
f38c615
Compare
@humphd, would it be possible to modify the feed list in the CDOT wiki to include your YouTube channel? I would like to see whether the back-end with the front-end would display the video. |
Done. I added this:
|
I will submit an issue to address this. |
I checked the preview deployment after @humphd added his YouTube feed to the CDOT wiki feed list. Here are the results: PC screens:Phone screens:This is on the screen resizing of the browser, so on an actual phone it might be different. It can be improved, but I am not sure how we would like to show it for mobile user (maybe with a redirect to the YouTube mobile app if they have it?). Let me know of any other small changes I may do. |
Awesome! In a follow-up, we should add a side-bar that includes YouTube links and the YouTube icon, like we do with GitHub info. @dbelokon can you file that for me please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a couple small things.
4160956
to
8693928
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
R+ with CI/CD passing.
Great work on implementing both backend and frontend. nit: I think the video could expand to full width on Mobile as the screen is smaller.
I tested this on my phone, clicking on the video title does redirect to the youtube app. We can still watch in the browser directly. |
e209c41
to
ef56c25
Compare
85b58d1
to
edbd934
Compare
@TDDR, since the reviews approved the changes and the PR is done, I'll be rebasing and merging once the CI checks have completed. |
Issue This PR Addresses
#1026: This will address the front end implementation for viewing videos in Telescope
Type of Change
Description
Display videos on the main timeline, processed by feed of a YouTube channel. This depends on PR #2581 to display any videos at all.
Checklist