-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start an MVP for including Twitch streams in Telescope #2728
Comments
Custom embeding <iframe
src="https://player.twitch.tv/?<channel, video, or collection>&parent=streamernews.example.com"
height="<height>"
width="<width>"
allowfullscreen="<allowfullscreen>">
</iframe> RSS: |
I am trying to find an example of how the youtube one was implemented to use as a reference. I can't find the PR/Issue though. Could someone show me where it is? |
cc @dbelokon, who wrote it all. |
These might help: They are the PRs she created to get the code in. |
This is perfect! It seems we can fork the project and use it in Telescope, as it uses Apache License, version 2.0, as long as we respect the License. Here's a TL;DR of the license. However, I would like to hear from @humphd for the final decision, as he is familiar with working with different open source licenses. For the embedding, I think we can use a module like |
If you want to use that app, someone needs to fix lzeke0/TwitchRSS#18 upstream so we can pull and run their app as a container. |
@dbelokon Could show to me where is the main part of the code that makes youtube work? |
@sirinoks, there is not a specific part on how the YouTube works, as it is treated like another RSS feed (thanks to the suggestions that Dave mentioned back in the review of the PR), so I can write a small guide on how the code ended up:
As you can see from the summary, I didn't do a huge rewrite to the backend, which is a big benefit~ Lemme know if you have any other questions 😄 |
https://hub.docker.com/r/rssbridge/rss-bridge/ is a more full-featured RSS bridge that is already containerized |
Research:
Look up the details for what we can do so we can potentially get started for 2.7.
The text was updated successfully, but these errors were encountered: