-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2461: Build Log dashboard should use same layout/CSS as rest of Dashboard #2480
Conversation
Currently, this PR is not fully completed, as I still have some stuff to discuss in #2472. |
What's the status of this? Also, please post a screenshot of it running. |
@humphd I'll push the rest of the changes up by today. |
b810879
to
2cdfb10
Compare
2cdfb10
to
ad22a4c
Compare
I have made some changes based on what was discussed in #2472: Screenshots:
|
* added header and sidenav * replaced Material UI logo in sidenav to Telescope's logo * removed spare double-quotes in svg link and scrollbar in sidenav * updated link in sidenav logo to redirect to ./ * added link to Telescope override css files * removed unused elements in top nav * updated links and titles in sidenav
ad22a4c
to
817d5e1
Compare
@mqnguyen5 can you do a single screenshot of the whole thing, which is really want we want to see here? |
Let's add a left margin to the terminal so it has some breathing room next to the sidebar. Also, let's have it go higher in the page (don't waste so much space above it). I think it can be aligned with the top of the sidebar. Let's also have it fill the available space vertically. |
If that's the case, should I remove the "Build Log" |
I think so, since the sidebar acts as the anchoring navigational element (we don't need a title). |
@Andrewnt219, @menghif you have any suggestions on this? |
@mqnguyen5 one quick way is you copy everything in the |
That sounds like JS magic. But why do you want to do this? This is just Bootstrap 5 with vanilla JS btw, not the same as Material UI on Telescope. |
After looking around, I managed to find out what is wrong. I didn't not realized that I had been showing screenshots of the site when opening in small window instead of going full screen. I also adjusted the padding on the terminal per @humphd suggestion, so it should take less space from the top now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and looks good on my end.
Issue This PR Addresses
Type of Change
Description
This issue updates the Build Log dashboard to have the same layout/CSS as the rest of the Telescope dashboard.
Changes:
./
Results:
Checklist