Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2433: Customize the dashboard so it looks like it belongs to Telescope #2472

Merged
merged 16 commits into from
Nov 20, 2021

Conversation

suhhee1011
Copy link
Contributor

@suhhee1011 suhhee1011 commented Nov 15, 2021

Issue This PR Addresses

FIxes #2433.

Type of Change

  • UI: Change which improves UI

Description

This issue was changing the UI of the Dash board page from default one from "Material Dashboard 2" to "Telescope".
The following parts are that I changed.

  • use the Telescope logo
  • use the Telescope favicon
  • Change "Material Dashboard 2" to "Telescope Dashboard"
  • Get rid of the "Upgrade to Pro" button
  • Get rid of copyright and other links in the footer
  • Change the primary color from reddish/purple to use the primary Telescope color

Screenshot for the changed UI of Dash board
1
2

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Nov 15, 2021

@suhhee1011 suhhee1011 requested a review from humphd November 15, 2021 23:32
@menghif menghif self-requested a review November 15, 2021 23:34
@manekenpix manekenpix changed the title issue#2433 minor changes Closes #2433: Customize the dashboard so it looks like it belongs to Telescope Nov 16, 2021
@humphd
Copy link
Contributor

humphd commented Nov 16, 2021

Can you rebase this so it pics up the changes in index.html?

Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like where this is going. I wonder if the dark black background is too much with our blue?

cc @PedroFonsecaDEV

src/api/status/public/index.html Outdated Show resolved Hide resolved
src/api/status/public/index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@menghif menghif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 😀

src/api/status/public/index.html Outdated Show resolved Hide resolved
src/api/status/public/index.html Outdated Show resolved Hide resolved
@menghif
Copy link
Contributor

menghif commented Nov 16, 2021

Screen Shot 2021-11-16 at 9 41 09 AM

One more thing, there is scrolling in the sidebar when it's not needed.

@mqnguyen5
Copy link
Contributor

I was working on #2461 and was having the same issue about the CSS styles override. The dashboard and the Build log all use the same side nav, so I was wondering if I should I only focus on changing the Build log UI to look like the old Dashboard UI first, and when this one get's merged, update the CSS to match with the Telescope color scheme.

@humphd what do you think?

@mqnguyen5
Copy link
Contributor

mqnguyen5 commented Nov 17, 2021

Also, I believe the reason that causes scrolling is because of this:

.navbar-vertical.navbar-expand-xs .navbar-collapse {
    display: block;
    overflow: auto;
    height: calc(100vh - 360px); --> this is causing scrolling
}

We can remove the scrollbar by removing the height property here, but overriding height like @suhhee1011 didn't seems to be working. @menghif any thoughts on this?

@menghif
Copy link
Contributor

menghif commented Nov 17, 2021

@mqnguyen5 I tried your suggestion to fix the scroll issue and it did not fix the problem. The issue goes away when removing the classes "collapse navbar-collapse" from here:

<div class="collapse navbar-collapse w-auto max-height-vh-100" id="sidenav-collapse-main">
I'm not sure if that's a good way to approach it though.

@mqnguyen5
Copy link
Contributor

mqnguyen5 commented Nov 17, 2021

@menghif I'll keep looking to see if I can find anything else. Thanks for the comment!

@humphd
Copy link
Contributor

humphd commented Nov 18, 2021

This is failing prettier, please setup your env correctly and/or run npm run prettier.

Can we get an updated screenshot of what this looks like? What's left to do on this?

Copy link
Contributor

@Andrewnt219 Andrewnt219 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on local, working great. Can you move style.css into the public/css folder, name it site.css and update its <link />?

src/api/status/public/style.css Outdated Show resolved Hide resolved
src/api/status/public/style.css Outdated Show resolved Hide resolved
@humphd humphd requested a review from Andrewnt219 November 18, 2021 19:14
@menghif
Copy link
Contributor

menghif commented Nov 18, 2021

One last thing, what happened to the "Dashboard" button?

Screen Shot 2021-11-18 at 3 54 47 PM

We should have "Dashboard" and then underneath "Build Log"

EDIT: this can be changed in a future issue

src/api/status/public/index.html Outdated Show resolved Hide resolved
@humphd
Copy link
Contributor

humphd commented Nov 18, 2021

@suhhee1011 these can get deleted:

Screen Shot 2021-11-18 at 6 08 12 PM

@humphd
Copy link
Contributor

humphd commented Nov 19, 2021

What's the status of this?

@suhhee1011
Copy link
Contributor Author

Almost done with editing by comment I will update pr in a hour :)

Copy link
Contributor

@Andrewnt219 Andrewnt219 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great, just some clean-up work.

src/api/status/public/css/site.css Show resolved Hide resolved
src/api/status/public/index.html Show resolved Hide resolved
src/api/status/public/style.css Outdated Show resolved Hide resolved
Andrewnt219
Andrewnt219 previously approved these changes Nov 20, 2021
Copy link
Contributor

@Andrewnt219 Andrewnt219 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, it's good to merge.

Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2021-11-19 at 7 54 35 PM

Please update the following:

  • Remove Tables, Billing, Virtual Reality, RTL, Notifications.
  • Change the text of "Account Pages" to "Telescope Links"
  • You repeat all the Telescope links twice. Get rid of the second set.

src/api/status/public/index.html Outdated Show resolved Hide resolved
@suhhee1011
Copy link
Contributor Author

image

menu item edited and link fixed
@humphd humphd merged commit 203766c into Seneca-CDOT:master Nov 20, 2021
@suhhee1011 suhhee1011 deleted the issue#2433 branch November 20, 2021 02:08
@PedroFonsecaDEV
Copy link
Contributor

PedroFonsecaDEV commented Nov 20, 2021

I like where this is going. I wonder if the dark black background is too much with our blue?

cc @PedroFonsecaDEV

@humphd
Sorry, I got here too late.
But I like it; I don't see any problems with the colour.
I really like where all of the UI/UX work is heading.
Amazing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customize the dashboard so it looks like it belongs to Telescope
7 participants