-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #2433: Customize the dashboard so it looks like it belongs to Telescope #2472
Conversation
Can you rebase this so it pics up the changes in index.html? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like where this is going. I wonder if the dark black background is too much with our blue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 😀
I was working on #2461 and was having the same issue about the CSS styles override. The dashboard and the Build log all use the same side nav, so I was wondering if I should I only focus on changing the Build log UI to look like the old Dashboard UI first, and when this one get's merged, update the CSS to match with the Telescope color scheme. @humphd what do you think? |
Also, I believe the reason that causes scrolling is because of this: .navbar-vertical.navbar-expand-xs .navbar-collapse {
display: block;
overflow: auto;
height: calc(100vh - 360px); --> this is causing scrolling
} We can remove the scrollbar by removing the |
@mqnguyen5 I tried your suggestion to fix the scroll issue and it did not fix the problem. The issue goes away when removing the classes
|
@menghif I'll keep looking to see if I can find anything else. Thanks for the comment! |
This is failing prettier, please setup your env correctly and/or run Can we get an updated screenshot of what this looks like? What's left to do on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on local, working great. Can you move style.css
into the public/css folder, name it site.css
and update its <link />?
@suhhee1011 these can get deleted: |
What's the status of this? |
Almost done with editing by comment I will update pr in a hour :) |
menu item edited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look great, just some clean-up work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, it's good to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
menu item edited and link fixed
@humphd |
Issue This PR Addresses
FIxes #2433.
Type of Change
Description
This issue was changing the UI of the Dash board page from default one from "Material Dashboard 2" to "Telescope".
The following parts are that I changed.
Screenshot for the changed UI of Dash board
Checklist