SearchBar (new PR)

[huyxgit]

Closes #1912

[huyxgit]

@HyperTHD @PedroFonsecaDEV @izhuravlev @rjayroso @humphd

[izhuravlev]

I mentioned that there is a slight movement of the whole SearchBar when you hover over the search and clear buttons. We might want to fix this and make the Search and Clear buttons more clickable.

Other than that I can approve this PR

[huyxgit]

@izhuravlev what movement? you meant outline? the 'focus' event's more important, as long as it stay on a click, 'hover' making some 'move' you said, however, this isn't negative. In term of visibility of search/clear button. it 'submit' when user hit 'enter' then no need to highlight the search button.

[chrispinkney]

Blocked until we get the advanced search stuff.

[HyperTHD]

@chrispinkney Advanced search was supposed to always go in another PR.
Not sure why the other one was closed, but this is GTM

[huyxgit]

@chrispinkney @HyperTHD Same, I wasn't really get this, because the advanced search will be in a separate PR, why do I need to wait for that to merge this PR? combining both into one?

[humphd]

@huynguyez we want these changes to land as a pair, since they depend on each other. If we land this and don't do the advanced search, we regress the search feature we have now.

You can make a branch off of this work to do the advanced bits, and then once we land, rebase on master.

[izhuravlev]

@huynguyez Do you need reviews for this now? Is it ready?

[TueeNguyen]

Hi @huyxgit, what's your progress on this PR?

[AmasiaNalbandian]

There is work in progress on the branch right here:
https://github.com/AmasiaNalbandian/telescope/tree/issue-2110-advancedsearch

I have cherry picked the beginning code for the modal, and have made more progress by implementing the backend for the advanced search from the PR that was added here: #2617

I am going to close this PR as it is abandoned, and I have picked up the issue.