Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchBar re-design #1912

Closed
huyxgit opened this issue Mar 12, 2021 · 8 comments · Fixed by #3211
Closed

SearchBar re-design #1912

huyxgit opened this issue Mar 12, 2021 · 8 comments · Fixed by #3211
Assignees
Labels

Comments

@huyxgit
Copy link

huyxgit commented Mar 12, 2021

Since I found UI problem with the current searchbar, I suggest a new design for it.

Any suggestion?
Thanks.

@huyxgit huyxgit added the type: enhancement New feature or request label Mar 12, 2021
@humphd humphd added this to the 1.9 Release milestone Mar 12, 2021
@humphd
Copy link
Contributor

humphd commented Mar 12, 2021

I like this. Question: what does clicking "Advanced Search" do? Can you include that?

Also, I think the language should be:

  1. "Search in Posts"
  2. "Search by Author"

@huyxgit
Copy link
Author

huyxgit commented Mar 12, 2021

@humphd as my idea, the SearchHelp will not be visible at first. People don't use it often, only 'power user' actually use, so it's better to hide it by default than seeing a big (i) or bunch of instruction texts letting people know how to search.

Only when user hit "Advanced search", it can either:

  • Redirect user to a separate page for advanced search.
  • Start to show SearchHelp as old design.

@PedroFonsecaDEV
Copy link
Contributor

PedroFonsecaDEV commented Mar 12, 2021

I really like this design.
@huynguyez, do you mind working on it and land it in 1.9?

@humphd
Copy link
Contributor

humphd commented Mar 12, 2021

Agreed, let's do this. Great work @huynguyez.

@humphd
Copy link
Contributor

humphd commented Mar 17, 2021

@huynguyez what's happening with this? I'd love to see this get in soon.

@huyxgit
Copy link
Author

huyxgit commented Mar 17, 2021

@humphd Still trying different ways to make it work better, probably I will push it before Friday

@humphd
Copy link
Contributor

humphd commented Mar 20, 2021

Friday came and went, any updates?

@huyxgit
Copy link
Author

huyxgit commented Mar 20, 2021

@humphd Sorry I messed up git Git again. just need to style it
Screen Shot 2021-03-20 at 2 57 41 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment