-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2042 - Add scroll-snap like behaviour on landing page #2080
Conversation
|
` @humphd . Npm run build doesn't fail locally. I don't know why |
You must have something installed locally that you didn't add to package.json, and is missing on Vercel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how this works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Work well locally!
We need a rebase on this. |
This solution is limited. It only works if you scroll and release your touchpad or mouse wheel. It won't work if you keep scrolling (overriding the scroll trigger). I will try to improve this later. |
I just rebased, can I get another review? |
It looks like this is still behind (needs another merge conflict fixed). If you do it, I'll review and land with you. |
Can you help merge when it's ready? |
Issue This PR Addresses
Type of Change
Description
Fixes #2042
100px
threshold, and scroll up on passingheight of banner - 50px
thresold.Checklist