Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing scroll snap on the front page #2445

Closed
DukeManh opened this issue Nov 3, 2021 · 1 comment
Closed

Consider removing scroll snap on the front page #2445

DukeManh opened this issue Nov 3, 2021 · 1 comment
Labels
area: front-end type: bug Something isn't working

Comments

@DukeManh
Copy link
Contributor

DukeManh commented Nov 3, 2021

I wanted to file this issue for a while now. In #2080, I introduced scroll-snap-like behavior on the landing page as suggested by #2042.
However, due to Telescope's layout, we couldn't use CSS scroll snap to do that but rather had a hacky solution by using an IntersectionObserver and promised to improve it.
I had been having trouble triggering scroll-snap behavior consistently. Plus it causes unexpected scrolls on mobile sometimes too.
I don't think scroll snap works for us and there's not a good way to simulate that feature.

There's a good article on why not to use this too.
https://alvarotrigo.com/blog/why-not-to-use-css-scroll-snap/

@DukeManh DukeManh added type: bug Something isn't working type: enhancement New feature or request area: front-end and removed type: enhancement New feature or request labels Nov 3, 2021
@manekenpix
Copy link
Member

@DukeManh I like this idea, but we should get more opinions. I'm going to convert this into a discussion here (good opportunity to see how that feature works).

@Seneca-CDOT Seneca-CDOT locked and limited conversation to collaborators Nov 3, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
area: front-end type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants