Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose JWT_ISSUER, JWT_AUDIENCE, and SECRET env vars to all services #2055

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Expose JWT_ISSUER, JWT_AUDIENCE, and SECRET env vars to all services #2055

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 30 additions & 14 deletions docker/production.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ services:
- ELASTIC_PORT=9200
- ELASTIC_URL=http://elasticsearch
# Environment values we expect from our legacy .env file
- NODE_ENV
- NODE_ENV=production
- PORT
- POSTS_URL
- API_URL
Expand Down Expand Up @@ -84,7 +84,15 @@ services:
context: ../src/api/status
dockerfile: Dockerfile
environment:
- NODE_ENV=production
- STATUS_PORT
# Satellite authentication/authorization support
- JWT_ISSUER
- JWT_AUDIENCE
- SECRET
# TODO - add APM monitoring support for Satellite
# - ELASTIC_APM_SERVER_URL
# - ELASTIC_APM_SERVICE_NAME
ports:
- '${STATUS_PORT}'
depends_on:
Expand All @@ -107,10 +115,13 @@ services:
environment:
- NODE_ENV=production
- IMAGE_PORT
# TODO
# - ELASTICSEARCH_HOSTS=http://elasticsearch:9200
# - ELASTIC_APM_SERVICE_NAME=image
# - ELASTIC_APM_SERVER_URL=http://apm:8200
# Satellite authentication/authorization support
- JWT_ISSUER
- JWT_AUDIENCE
- SECRET
# TODO - add APM monitoring support for Satellite
# - ELASTIC_APM_SERVER_URL
# - ELASTIC_APM_SERVICE_NAME

# auth service
auth:
Expand All @@ -119,7 +130,6 @@ services:
- NODE_ENV=production
- AUTH_PORT
# TODO
# - ELASTICSEARCH_HOSTS=http://elasticsearch:9200
# - ELASTIC_APM_SERVICE_NAME=auth
# - ELASTIC_APM_SERVER_URL=http://apm:8200

Expand All @@ -129,20 +139,26 @@ services:
environment:
- NODE_ENV=production
- POSTS_PORT
# TODO
# - ELASTICSEARCH_HOSTS=http://elasticsearch:9200
# - ELASTIC_APM_SERVICE_NAME=posts
# - ELASTIC_APM_SERVER_URL=http://apm:8200
# Satellite authentication/authorization support
- JWT_ISSUER
- JWT_AUDIENCE
- SECRET
# TODO - add APM monitoring support for Satellite
# - ELASTIC_APM_SERVER_URL
# - ELASTIC_APM_SERVICE_NAME

# users service
users:
restart: unless-stopped
environment:
- NODE_ENV=production
# TODO
# - ELASTICSEARCH_HOSTS=http://elasticsearch:9200
# - ELASTIC_APM_SERVICE_NAME=user
# - ELASTIC_APM_SERVER_URL=http://apm:8200
# Satellite authentication/authorization support
- JWT_ISSUER
- JWT_AUDIENCE
- SECRET
# TODO - add APM monitoring support for Satellite
# - ELASTIC_APM_SERVER_URL
# - ELASTIC_APM_SERVICE_NAME
volumes:
# This will take care of copying the serviceAccountKey.json file needed by firestore.js
- ../../firebase/serviceAccountKey.json:/app/serviceAccountKey.json
Expand Down