Expose JWT_ISSUER, JWT_AUDIENCE, and SECRET env vars to all services #2055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 30, 2021
birtony
previously approved these changes
Mar 31, 2021
|
I'm assuming we plan on updating the posts service's routes as well as the any other future service to only be accessed by an authenticated user with this change |
|
Yeah, we need to add middleware for the JWT stuff in all routes that modify any data, or should be hidden behind admin. |
|
DevelopingSpace/satellite#10 just landed and needs this. |
manekenpix
previously approved these changes
Apr 5, 2021
humphd
force-pushed
the
envs-for-satellite
branch
from
b41ca6f to
e2d73e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Satellite we have
isAutenticated()middleware that depends on a service knowing some info about our JWT setup. Also, we're adding the ability for a service token to be created in each service, which means we need to share even more details with the services. To do this, we expect environment variables to be set in Satellite. Previously we weren't doing this, but this PR adds them in.Future services will also require this (FYI @c3ho for Parser and @izhuravlev for Search).
We were also missing some
NODE_ENV=productionvariables, which I've added. They will always need to beproductionin production, so it's best to do it in the docker-compose file vs. the env.Finally, I've stubbed out (with comments) the APM values we'll need later on when we add those, so it's clear what's missing.