-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1420 - site crash when no post found #1742
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/humphd/telescope/grjlwgz7r |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic, nice work!
@DukeManh while you're hacking on this code, do you want to do another fix for me (new PR)? When the page initially loads, we get a loading spinner before anything is typed: https://telescope-lweq34q54.vercel.app/search Let's not show anything at all until a search has been conducted. |
@DukeManh you already got 2 Approvals, so you can go ahead and rebase your PR, and after that, you can merge (or ping any of us and we will merge it for you) |
|
Can you merge it for me, I don't have write access to Telescope yet. |
Issue This PR Addresses
Fixes: #1420
Type of Change
Description
Checklist