Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1420 - site crash when no post found #1742

Merged
merged 2 commits into from
Feb 15, 2021

Conversation

DukeManh
Copy link
Contributor

@DukeManh DukeManh commented Feb 14, 2021

Issue This PR Addresses

Fixes: #1420

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@vercel
Copy link

vercel bot commented Feb 14, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/humphd/telescope/grjlwgz7r
✅ Preview: https://telescope-git-fork-dukemanh-issue-1420b.humphd.vercel.app

Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, nice work!

@humphd
Copy link
Contributor

humphd commented Feb 14, 2021

@DukeManh while you're hacking on this code, do you want to do another fix for me (new PR)? When the page initially loads, we get a loading spinner before anything is typed:

https://telescope-lweq34q54.vercel.app/search

Let's not show anything at all until a search has been conducted.

@izhuravlev
Copy link
Contributor

@DukeManh you already got 2 Approvals, so you can go ahead and rebase your PR, and after that, you can merge (or ping any of us and we will merge it for you)

@DukeManh
Copy link
Contributor Author

DukeManh commented Feb 14, 2021

@DukeManh while you're hacking on this code, do you want to do another fix for me (new PR)? When the page initially loads, we get a loading spinner before anything is typed:

https://telescope-lweq34q54.vercel.app/search

Let's not show anything at all until a search has been conducted.
Sounds good. I'll make it renders nothing when there's no search yet.

@DukeManh
Copy link
Contributor Author

@DukeManh you already got 2 Approvals, so you can go ahead and rebase your PR, and after that, you can merge (or ping any of us and we will merge it for you)

Can you merge it for me, I don't have write access to Telescope yet.

@humphd humphd merged commit 2919f2c into Seneca-CDOT:master Feb 15, 2021
@DukeManh DukeManh deleted the issue-1420_b branch March 24, 2021 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: front-end area: nextjs Nextjs related issues type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site CRASH: "load more posts" in EMPTY search result
5 participants