Site CRASH: "load more posts" in EMPTY search result

[huyxgit]

When user try to search with keywords that returns no result, now it showing "load more posts" instead of showing something like "no result". When click on "load more posts" button, the web crash in ~20-30 secs.

This one maybe relate to #1415, or sth else.

[humphd]

Nice catch @VIETNAMEZE. Did I see a bug somewhere else to remove the "Load More Posts" button completely? cc @PedroFonsecaDEV.

[humphd]

Steps To Reproduce:

1. Go to Search
2. Select Post as the filter
3. Type in paul sinj (or any text that doesn't exist in a post)
4. Click the LOAD MORE POSTS button
5. Open the DevTools Network tab
6. Watch it load page after page of non-results
7. Eventually it hits page 999, and on page 1000 returns a 400 and renders null (white screen)

cc @joelazwar

[joelazwar]

Hmm yeah we need to code something to detect when it has all the results or else itll keep fetching at the bottom of the page. Working on something for #1408 that also might fix this

[DukeManh]

I think I know what the cause is, useSWRInfinite returns an array of pages where data[0] is an array of posts on the first page. To determine if the search returns nothing we should check for empty data[0] rather than data because ([ [] ]) is truthy.

[DukeManh]

I filed #1739, quick fix for this.

[PedroFonsecaDEV]

I filed #1739, quick fix for this.

Thanks @DukeManh.
Please feel free to join us on Slack! You are more than welcome!

[DukeManh]

I'm very happy to contribute. I already joined the server.

[DukeManh]

The new properly rebased PR is #1742