Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #1682 - rewrote buttons to be clickable on the entire but… #1701

Merged
merged 1 commit into from
Feb 15, 2021

Conversation

izhuravlev
Copy link
Contributor

…ton space

Issue This PR Addresses

Fixes #1682

I tried to add a Gif, but ChromeCapture did not work normally in the DevTools window in Chrome.

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@izhuravlev izhuravlev self-assigned this Feb 12, 2021
@izhuravlev izhuravlev added area: front-end area: nextjs Nextjs related issues labels Feb 12, 2021
@izhuravlev izhuravlev added this to the 1.7 Release milestone Feb 12, 2021
@izhuravlev izhuravlev changed the title Fixed issue #1682 - rewrote buttons to be clickable on the entire bot… Fixed issue #1682 - rewrote buttons to be clickable on the entire but… Feb 12, 2021
@izhuravlev
Copy link
Contributor Author

I just mentioned that we are focusing on the new UI and this commit is basically useless.

HyperTHD
HyperTHD previously approved these changes Feb 13, 2021
Copy link
Contributor

@HyperTHD HyperTHD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@izhuravlev
Copy link
Contributor Author

Thank you @HyperTHD for the recording!

chrispinkney
chrispinkney previously approved these changes Feb 14, 2021
Copy link
Contributor

@chrispinkney chrispinkney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled and ran locally. Awesome, perfect, wonderful, stupendous, LGTM.

@izhuravlev
Copy link
Contributor Author

I will rebase now, as I have 2 Approvals, and merge this PR.

Thank you @HyperTHD and @chrispinkney!

@vercel
Copy link

vercel bot commented Feb 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/humphd/telescope/3867gnfpw
✅ Preview: https://telescope-git-fork-izhuravlev-issue-1682.humphd.now.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: front-end area: nextjs Nextjs related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix onClick reaction area in Next.js MobileHeader
3 participants