Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix onClick reaction area in Next.js MobileHeader #1682

Closed
izhuravlev opened this issue Feb 9, 2021 · 0 comments · Fixed by #1701 or #1703
Closed

Fix onClick reaction area in Next.js MobileHeader #1682

izhuravlev opened this issue Feb 9, 2021 · 0 comments · Fixed by #1701 or #1703
Assignees
@izhuravlev
Labels
5 min fix Fixable in 5 minutes or less area: css styling Anything related to CSS styling area: nextjs Nextjs related issues type: bug Something isn't working
Milestone
1.7 Release

Comments

@izhuravlev
Copy link
Contributor

What happened: After porting MobileHeader to Next.js, buttons in the side-menu react only when clicked precisely on the text.

What should have happened: They should react when clicked a little bit to the side as well - the onClick area should be increased

How to reproduce it (as precise as possible): Start the Next.js version of the Front-end, open the mobile view, open the side-menu and try clicking not on the text on any of the buttons, but a bit to the side.

Anything else we need to know?:

Environment:
Have been noticed only in the mobile version, but you might want to check the desktop as well.

  • OS:
  • Browser:
@izhuravlev izhuravlev added type: bug Something isn't working area: css styling Anything related to CSS styling area: nextjs Nextjs related issues labels Feb 9, 2021
@izhuravlev izhuravlev added the 5 min fix Fixable in 5 minutes or less label Feb 9, 2021
@yuanLeeMidori yuanLeeMidori added this to the 1.7 Release milestone Feb 9, 2021
izhuravlev added a commit to izhuravlev/telescope that referenced this issue Feb 12, 2021
@izhuravlev
Fixed issue Seneca-CDOT#1682 - rewrote buttons to be clickable on the…
3b1dce8 
… entire botton space
izhuravlev added a commit to izhuravlev/telescope that referenced this issue Feb 12, 2021
@izhuravlev
Fixed issue Seneca-CDOT#1682 - rewrote buttons to be clickable on the…
f57c374 
… entire botton space
This was referenced Feb 12, 2021
Merged
Merged
izhuravlev added a commit to izhuravlev/telescope that referenced this issue Feb 15, 2021
@izhuravlev
Fixed issue Seneca-CDOT#1682 - rewrote buttons to be clickable on the…
3cc375e 
… entire botton space
izhuravlev added a commit that referenced this issue Feb 15, 2021
@izhuravlev
Merge pull request #1701 from izhuravlev/Issue-1682
c9b73bf 
Fixed issue #1682 - rewrote buttons to be clickable on the entire but…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@izhuravlev izhuravlev

Labels
5 min fix Fixable in 5 minutes or less area: css styling Anything related to CSS styling area: nextjs Nextjs related issues type: bug Something isn't working
Projects
None yet
Milestone
1.7 Release
2 participants
@izhuravlev @yuanLeeMidori