Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catlinks at the bottom of all the content and fix the overlapped footer #22

Merged
merged 3 commits into from
Mar 17, 2018

Conversation

ivanhercaz
Copy link
Contributor

Trying to solve #9, I think one solution might be to use this little snippet (first commit):

#catlinks {
	clear: right;
}

I added at the bottom of the stylesheet but if you think it should be in another place, you can replace it without problems (my PRs allow edits from maintainers).

But, in the another hand, I detect one problem with the footer when it is in a mobile device. This is the current result (and error):

smwcon spring 2012 semantic mediawiki org 1

And this is how it looks after disable the bottom: 0 in .smwofootergrid.container, that I deleted in the second commit of this PR:

smwcon spring 2012 semantic mediawiki org 2

@kghbln, could we test in smw.o? I hope it works and solved both issues.

Regards,
Iván

Removing this would kill the display if only few content is added to a page
@kghbln
Copy link
Member

kghbln commented Mar 17, 2018

And this is how it looks after disable the bottom: 0 in .smwofootergrid.container, that I deleted in the second commit of this PR:

I guess this is about fixing one issue and adding another one. If I remove this the display on pages like this one is borked.

Moreover I do not see this behaviour you wanted to address, admittedly only by narrowing the browser on a desctop pc.

@kghbln kghbln merged commit d214ffc into SemanticMediaWiki:master Mar 17, 2018
@kghbln
Copy link
Member

kghbln commented Mar 17, 2018

But, in the another hand, I detect one problem with the footer when it is in a mobile device. This is the current result (and error):

Can you at least scroll?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants