Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icons] Fix #6231 Legacy FontAwesome classes point to the wrong icon #6232

Closed
wants to merge 1 commit into from

Conversation

NoisyFlake
Copy link

Fixes #6231

Includes the following icons:

cloud.download
cloud.upload
disk.outline
exchange
heart.empty
hourglass.zero
protect
resize.horizontal
resize.vertical
star.empty

Fixed cloud.download
Fixed cloud.upload
Fixed disk.outline
Fixed exchange
Fixed heart.empty
Fixed hourglass.zero
Fixed protect
Fixed resize.horizontal
Fixed resize.vertical
Fixed star.empty
@NoisyFlake NoisyFlake changed the title [Icons] Fixes #6231 [Icons] Fixes #6231 Legacy FontAwesome classes point to the wrong icon Mar 1, 2018
@NoisyFlake NoisyFlake changed the title [Icons] Fixes #6231 Legacy FontAwesome classes point to the wrong icon [Icons] Fix #6231 Legacy FontAwesome classes point to the wrong icon Mar 1, 2018
@jlukic jlukic added this to the 2.3.1 milestone Mar 7, 2018
jlukic added a commit that referenced this pull request Mar 19, 2018
@jlukic
Copy link
Member

jlukic commented Mar 19, 2018

I've checked each of these icons against the next build and I believe they should all be fixed now. We've separated out the outline, brand, and solid fonts in #6181

@jlukic jlukic closed this Mar 19, 2018
@albb0920
Copy link

I got missing icon after I upgrade from 2.2 to 2.3.2.
It seems like disk.outline in still missing.

Demo
http://jsfiddle.net/a9zvdw6j/10/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants