Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icons] Icons removed in FontAwesome 5 are wrong #6231

Open
NoisyFlake opened this issue Mar 1, 2018 · 3 comments
Open

[Icons] Icons removed in FontAwesome 5 are wrong #6231

NoisyFlake opened this issue Mar 1, 2018 · 3 comments
Labels

Comments

@NoisyFlake
Copy link

NoisyFlake commented Mar 1, 2018

Some icons that were removed in FontAwesome 5 but were kept for compatibility reasons point to the wrong icons. Example:

i.icon.resize.horizontal has content: "\f337" which correlates to i.icon.envelope.open.outline.
Instead it shoud point to the new i.icon.arrows.alternate.horizontal which has content: "\f697".

Other classes I found that point to the wrong icon:

cloud.download
cloud.upload
disk.outline
exchange
heart.empty
hourglass.zero
protect
resize.horizontal
resize.vertical
star.empty

The rest seems to be mostly fine (or as good as possible as not every old icon has a fitting replacement).

NoisyFlake pushed a commit to NoisyFlake/Semantic-UI that referenced this issue Mar 1, 2018
Fixed cloud.download
Fixed cloud.upload
Fixed disk.outline
Fixed exchange
Fixed heart.empty
Fixed hourglass.zero
Fixed protect
Fixed resize.horizontal
Fixed resize.vertical
Fixed star.empty
@rtarnaud
Copy link

rtarnaud commented Mar 5, 2018

The icons i.icon.arrows.alternate.horizontal and i.icon.arrows.alternate.vertical do not seem to work in 2.3.0. They indeed point to the right values (\f337 and \f338 respectively) according to the FA5 cheatsheet. Any idea why?

@NoisyFlake
Copy link
Author

@rtarnaud: This is already fixed in v2.3.1 (which is deployed to the docs page), but it's not officially released yet.

@stale
Copy link

stale bot commented Jun 4, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants