Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Segment/Table] Some Attached Off by 1px #4248

Closed
brianjenkins94 opened this issue Jul 8, 2016 · 3 comments
Closed

[Segment/Table] Some Attached Off by 1px #4248

brianjenkins94 opened this issue Jul 8, 2016 · 3 comments
Milestone

Comments

@brianjenkins94
Copy link

brianjenkins94 commented Jul 8, 2016

screen shot 2016-07-08 at 3 08 58 pm

I'm having an alignment issue with the version of Semantic UI served from https://cdnjs.cloudflare.com/ajax/libs/semantic-ui/2.2.1/semantic.css.

When populating a grid with elements such as ui top attached vertical menu and ui bottom attached compact menu the resulting rendered elements do not appear to line up properly.

My suspicion is that there is an off-by-one error related to a negative margin value.

I have provided the code I am working with in the following codepen: http://codepen.io/brianjenkins94/pen/LkzGBp

And I've got to say, I've only been using Semantic UI for two days now and I love it. Keep up the great work!

Edit: I just updated to 2.2.2 and the problem persists. Additionally, I neglected to mention the following:


Google Chrome: 51.0.2704.103 (Official Build) (64-bit)
OS: Mac OS X 10.11.5 El Capitan
JavaScript: V8 5.1.281.65

@wyemun
Copy link

wyemun commented Jul 14, 2016

Confirmed. It happens to .ui.table too

@brianjenkins94
Copy link
Author

Just realized it's happening on the example site Attached Content too.

@jlukic jlukic changed the title [Collections] Grid elements are not aligning as expected. Some Attached Off by 1px Jul 29, 2016
@jlukic jlukic added this to the 2.2.4 milestone Jul 29, 2016
@jlukic jlukic modified the milestones: 2.2.6, 2.2.7, 2.2.8 Oct 28, 2016
@jlukic jlukic changed the title Some Attached Off by 1px [Segment/Table] Some Attached Off by 1px Feb 20, 2017
@jlukic jlukic modified the milestones: 2.2.10, 2.2.11 Mar 28, 2017
@jlukic
Copy link
Member

jlukic commented Jul 3, 2017

@brianjenkins94

If you swap each menu in your code to use fluid and remove the inline css it doesnt have the alignement issues.

There was an adjacent issue with (x) item attached menu
http://jsfiddle.net/hpxg905w/

I've gone ahead and fixed that issue in the below commit in 2.2.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants