Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tab] - Evenly divided tabs pixel offset between last tab and segment #4235

Open
larsbo opened this issue Jul 7, 2016 · 4 comments
Open

Comments

@larsbo
Copy link
Contributor

larsbo commented Jul 7, 2016

Steps to Reproduce

  1. Create an evenly divided tabular menu, e.g. ui top attached three item tabular menu.
  2. Create corresponding segments, e.g. ui bottom attached tab segment.
  3. add required javascript, e.g. $('.menu .item').tab();.

Expected
The border of the last tab of an evenly divided tabluar menu should match with the border of the attached segment.

Result
There is a small offset (1 pixel) between tab border and segment border.

Testcase
http://jsfiddle.net/9ux939ro/
(second example)

@vinayakkulkarni
Copy link
Member

Was playing around with tabs today and noticed it.

it happens because of this:

.ui.attached.segment {
    width: calc(100% + 2px );
    max-width: calc(100% + 2px );

if you set

calc(100% + 1px);

it's fixed

@awgv
Copy link
Member

awgv commented Mar 15, 2017

This might be related: #4248.

@awgv awgv added this to the Needs Milestone milestone Mar 15, 2017
@stale
Copy link

stale bot commented Jun 5, 2018

There has been no activity in this thread for 90 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 90 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!

@stale stale bot added the stale label Jun 5, 2018
@lubber-de

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants