Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Popup): ignore clicks when on prop is set to hover only #3667

Merged
merged 2 commits into from
Aug 4, 2019

Conversation

ecnaidar
Copy link
Contributor

@ecnaidar ecnaidar commented Jun 17, 2019

Fixes #2583.

This PR fixes incorrect behavior when on has hover value: implicitly it worked it the same way as on=['click', 'hover'].

To preserve previous behavior default value for on is now ['click', 'hover'].

@welcome
Copy link

welcome bot commented Jun 17, 2019

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

codecov-io commented Jun 17, 2019

Codecov Report

Merging #3667 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3667      +/-   ##
==========================================
- Coverage   99.83%   99.81%   -0.03%     
==========================================
  Files         175      174       -1     
  Lines        3122     2757     -365     
==========================================
- Hits         3117     2752     -365     
  Misses          5        5
Impacted Files Coverage Δ
src/modules/Popup/Popup.js 98.46% <100%> (-0.23%) ⬇️
src/elements/Button/Button.js 94.28% <0%> (-1.17%) ⬇️
src/modules/Sticky/Sticky.js 98.91% <0%> (-0.18%) ⬇️
src/modules/Search/Search.js 99.46% <0%> (-0.09%) ⬇️
src/modules/Transition/TransitionGroup.js 100% <0%> (ø) ⬆️
src/addons/Ref/RefFindNode.js 100% <0%> (ø) ⬆️
src/addons/Pagination/Pagination.js 100% <0%> (ø) ⬆️
src/addons/Pagination/PaginationItem.js 100% <0%> (ø) ⬆️
src/modules/Modal/Modal.js 100% <0%> (ø) ⬆️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 781a1ff...51e6c1f. Read the comment docs.

@layershifter layershifter changed the title fix(Popup): ignore clicks when 'on' prop is set to 'hover' fix(Popup): ignore clicks when on prop is set to hover only Aug 4, 2019
@layershifter layershifter merged commit 474817d into Semantic-Org:master Aug 4, 2019
@welcome
Copy link

welcome bot commented Aug 4, 2019

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popover ignores "on" property if mouseEnterDelay is set
3 participants