Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover ignores "on" property if mouseEnterDelay is set #2583

Closed
nfantone opened this issue Feb 26, 2018 · 6 comments · Fixed by #3667
Closed

Popover ignores "on" property if mouseEnterDelay is set #2583

nfantone opened this issue Feb 26, 2018 · 6 comments · Fixed by #3667
Labels

Comments

@nfantone
Copy link

nfantone commented Feb 26, 2018

✔ BUGS → This form is required:

Steps

  1. Define a <Popup> component with a mouseEnterDelay property.
  2. Set on="hover" so it is triggered only on hover.
  3. Click on trigger element before mouseEnterDelay time expires.

Expected Result

The Popup opens only on hover, after mouseEnterDelay milliseconds, ignoring click events. It doesn't open if I click the trigger component.

Actual Result

The Popup is opened.

Version

0.78.3

Testcase

Edit Semantic UI React

@welcome
Copy link

welcome bot commented Feb 26, 2018

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

@levithomason
Copy link
Member

When according to your screenshot, you'd need to leave the mouse on the button for 10 seconds before the popup would open. In the CodeSandbox provided, the value was 2s.

When hover and leave the mouse over the button for 2s, it works as expected:

http://g.recordit.co/l15GuEuDbK.gif

@nfantone
Copy link
Author

nfantone commented Feb 26, 2018

@levithomason You misread the issue. The popup is being triggered on click, in addition to the hover event. Your explanation was a paraphrase of mine.

Expected Result
The Popup opens only on hover, after mouseEnterDelay milliseconds, ignoring click events.

Please, consider re-opening?

@nfantone
Copy link
Author

@levithomason Ping?

@ecnaidar
Copy link
Contributor

Still present in current version
Should only appear after 5s of hovering but shown immediately if clicked

https://codesandbox.io/s/lgonz

@nfantone
Copy link
Author

Nice that after over a year and a half this is still closed and labelled as "invalid".

Thanks @ecnaidar for your follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants