-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Dropdown): add 'closeOnEscape' prop #3632
feat(Dropdown): add 'closeOnEscape' prop #3632
Conversation
Signed-off-by: mhatvan <[email protected]>
💖 Thanks for opening this pull request! 💖 Here is a list of things that will help get it across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov Report
@@ Coverage Diff @@
## master #3632 +/- ##
==========================================
+ Coverage 99.81% 99.81% +<.01%
==========================================
Files 174 174
Lines 2747 2749 +2
==========================================
+ Hits 2742 2744 +2
Misses 5 5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
* feat(Dropdown): add 'closeOnEscape' prop (Semantic-Org#3622) Signed-off-by: mhatvan <[email protected]> * Update Dropdown-test.js
Fixes #3622.