Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Dropdown): add 'closeOnEscape' prop #3632

Merged
merged 3 commits into from
Jun 9, 2019
Merged

feat(Dropdown): add 'closeOnEscape' prop #3632

merged 3 commits into from
Jun 9, 2019

Conversation

mcmxcdev
Copy link
Contributor

Fixes #3622.

@welcome
Copy link

welcome bot commented May 29, 2019

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

codecov-io commented May 29, 2019

Codecov Report

Merging #3632 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3632      +/-   ##
==========================================
+ Coverage   99.81%   99.81%   +<.01%     
==========================================
  Files         174      174              
  Lines        2747     2749       +2     
==========================================
+ Hits         2742     2744       +2     
  Misses          5        5
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5db5f09...ae16fca. Read the comment docs.

Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@layershifter layershifter changed the title feat(Dropdown): add 'closeOnEscape' prop (#3622) feat(Dropdown): add 'closeOnEscape' prop Jun 9, 2019
@layershifter layershifter merged commit 8950d7c into Semantic-Org:master Jun 9, 2019
@welcome
Copy link

welcome bot commented Jun 9, 2019

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

mbakiev pushed a commit to mbakiev/Semantic-UI-React that referenced this pull request Jun 17, 2019
* feat(Dropdown): add 'closeOnEscape' prop (Semantic-Org#3622)

Signed-off-by: mhatvan <[email protected]>

* Update Dropdown-test.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown: add closeOnEscape prop
3 participants