Dropdown: add closeOnEscape prop
#3622
Labels
Comments
|
👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. |
gencer
changed the title
closeOnBlur={false} and ESC key not workingcloseOnBlur={false} and ESC key not working as expected
|
We have |
layershifter
changed the title
closeOnBlur={false} and ESC key not working as expectedcloseOnEscape prop
|
Ah, yes, we should have that for Dropdown too. BTW, Is there any workaround for this until this prop added to Dropdown? Any suggestions? /cc @layershifter |
layershifter
pushed a commit
that referenced
this issue
Jun 9, 2019
* feat(Dropdown): add 'closeOnEscape' prop (#3622) Signed-off-by: mhatvan <[email protected]> * Update Dropdown-test.js
mbakiev
pushed a commit
to mbakiev/Semantic-UI-React
that referenced
this issue
Jun 17, 2019
* feat(Dropdown): add 'closeOnEscape' prop (Semantic-Org#3622) Signed-off-by: mhatvan <[email protected]> * Update Dropdown-test.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Report
Steps
closeOnBlur={false}to dropdownESC.Expected Result
Clicking outside and pressing
ESCshould not close the dropdown. I want my dropdown stay open. The reason is, I put some elements in dropdown and it has its own keybindings.ESCis one of them and when I pressESCon that element, dropdown closes completely.Actual Result
Click works.
ESCcloses dropdown no matter of what.Version
0.87.1
Testcase
See "Close on blur stays open" example in SemanticUI-React website.
Related
See here: #1995
The text was updated successfully, but these errors were encountered: