fix(jQuery): weaken window.jQuery error #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| debug('Loading jQuery') | ||
| // load jQuery, then load SUI jQuery | ||
| window.jQuery = window.$ = require('jquery') | ||
| window.jQuery = window.$ = jQuery || require('jquery') |
There was a problem hiding this comment.
Prevents overriding window.jQuery if it exists, which was the source of jQuery extension issues in the past.
Current coverage is 92.57% (diff: 100%)
|
|
Could you confirm the doc site form validation works as expected with this setup? |
dvdzkwsk
force-pushed
the
fix/jquery
branch
2 times, most recently
from
7cb3d7d
to
19946fd
Compare
|
🉑 |
|
Confirmed it works with and without jQuery on the window @levithomason . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #352