Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw error if jquery is detected #352

Closed
wallslide opened this issue Jul 28, 2016 · 2 comments
Closed

Don't throw error if jquery is detected #352

wallslide opened this issue Jul 28, 2016 · 2 comments

Comments

@wallslide
Copy link

The error that is thrown here was preventing our app from loading:
https://github.com/TechnologyAdvice/stardust/blob/3d3dab56d1de1a87b946f77c7f04ffc7cfbb48fa/src/utils/jquery.js#L14

jquery might be loaded for any number of reasons. I don't think it's reasonable to throw an error if it exists. Just not using it within stardust should be enough. In our case, we're using stardust in a Meteor app. Meteor makes it notoriously difficult to remove jquery completely, although we're trying.

@levithomason
Copy link
Member

The reason it is an error is because the Semantic UI form plugin has not yet been removed, see #247. That plugin needs to extend your jquery in order for it to work. This was added to solve duplicate jQuery issues other users were having.

As you can see in the linked issue, jQuery will soon be removed entirely and we'll all be much better off. For now, we can demote this error to a console error.

@levithomason
Copy link
Member

@wallslide fixed and released, install the latest version and give it a go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants