Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Placeholder): add component #3172

Merged
merged 7 commits into from
Sep 24, 2018
Merged

feat(Placeholder): add component #3172

merged 7 commits into from
Sep 24, 2018

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Sep 24, 2018 •
edited
Loading

feat(Placeholder): add component
7363e78 
Signed-off-by: Oleksandr Fediashov <[email protected]>
@layershifter layershifter mentioned this pull request Sep 24, 2018
Merged
5 tasks
docs(Placeholder): finish docs
9eb13e8 
Signed-off-by: Oleksandr Fediashov <[email protected]>
@codecov-io
Copy link

codecov-io commented Sep 24, 2018 •
edited
Loading

Codecov Report

Merging #3172 into chore/update-sui will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           chore/update-sui    #3172      +/-   ##
====================================================
+ Coverage             99.92%   99.92%   +<.01%     
====================================================
  Files                   163      168       +5     
  Lines                  2746     2780      +34     
====================================================
+ Hits                   2744     2778      +34     
  Misses                    2        2
Impacted Files Coverage Δ
src/elements/Placeholder/PlaceholderHeader.js 100% <100%> (ø)
src/elements/Placeholder/PlaceholderImage.js 100% <100%> (ø)
src/elements/Placeholder/PlaceholderParagraph.js 100% <100%> (ø)
src/elements/Placeholder/Placeholder.js 100% <100%> (ø)
src/elements/Placeholder/PlaceholderLine.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0ad92b...fc8a9dc. Read the comment docs.

test(Placeholder): add tests
0de3cf8 
Signed-off-by: Oleksandr Fediashov <[email protected]>
@layershifter layershifter changed the title [WIP] feat(Placeholder): add component eat(Placeholder): add component Sep 24, 2018
@layershifter layershifter changed the title eat(Placeholder): add component feat(Placeholder): add component Sep 24, 2018
Oleksandr Fediashov added 4 commits September 24, 2018 17:44
docs(Placeholder): fix typo
8c4f4d0 
Signed-off-by: Oleksandr Fediashov <[email protected]>
feat(Placeholder): add exports of typings
26b4623 
Signed-off-by: Oleksandr Fediashov <[email protected]>
fix(Placeholder): fix typings
c7df201 
Signed-off-by: Oleksandr Fediashov <[email protected]>
fix(Placeholder): fix typings and examples' names
fc8a9dc 
Signed-off-by: Oleksandr Fediashov <[email protected]>
@layershifter layershifter merged commit 3b4fcce into chore/update-sui Sep 24, 2018
@layershifter layershifter deleted the feat/placeholder branch September 24, 2018 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@layershifter @codecov-io