chore(package): update to SUI 2.4.0 #3162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3162 +/- ##
==========================================
+ Coverage 99.92% 99.92% +<.01%
==========================================
Files 163 169 +6
Lines 2746 2801 +55
==========================================
+ Hits 2744 2799 +55
Misses 2 2
Continue to review full report at Codecov.
|
* feat(Placeholder): add component
Signed-off-by: Oleksandr Fediashov <[email protected]>
…to chore/update-sui # Conflicts: # docs/src/components/Document.js
feat(Segment): add `placeholder`
Signed-off-by: Oleksandr Fediashov <[email protected]>
layershifter
changed the title
layershifter
commented
Oct 2, 2018
| @@ -13,7 +13,7 @@ const Document = ({ Body, children, Head, Html, siteData: { dev, versions } }) = | |||
| <link rel='stylesheet' href='/style.css' /> | |||
| <link | |||
| rel='stylesheet' | |||
| href={`https://cdnjs.cloudflare.com/ajax/libs/semantic-ui/${versions.sui}/semantic.min.css`} | |||
| href={`https://cdn.jsdelivr.net/npm/semantic-ui-css@${versions.sui}/semantic.min.css`} | |||
There was a problem hiding this comment.
CDNJS doesn't contain the latest version, cdnjs/cdnjs#12953
added 3 commits
October 2, 2018 12:55
Signed-off-by: Oleksandr Fediashov <[email protected]>
…React into chore/update-sui
Signed-off-by: Oleksandr Fediashov <[email protected]>
layershifter
force-pushed
the
chore/update-sui
branch
from
94021a2
to
ed4c8e3
Compare
Signed-off-by: Oleksandr Fediashov <[email protected]>
This was referenced Oct 10, 2018
Closed
|
Released in |
|
Hi there, I updated packages "semantic-ui-css": "^2.4.0" and "semantic-ui-react": "^0.83.0". When I using the IE, the top left corner of the modal is the center of the page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3135.
Placeholdercomponent (feat(Placeholder): add component #3172)placeholdertoSegment(feat(Segment): addplaceholder#3182)clearableto Dropdown (feat(Dropdown): addclearableprop #3188)ukalias tonameinFlag