Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2531 moonpay sdk #2532

Merged
merged 10 commits into from
Dec 22, 2020
Merged

2531 moonpay sdk #2532

merged 10 commits into from
Dec 22, 2020

Conversation

sk91
Copy link
Contributor

@sk91 sk91 commented Dec 19, 2020 •
edited
Loading

please review and merge #2529 first

@sk91 sk91 added the Work-In-Progress This PR is incomplete. Do not merge. label Dec 19, 2020
@sk91 sk91 self-assigned this Dec 19, 2020
@coveralls
Copy link

coveralls commented Dec 19, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 18674

  • 219 of 225 (97.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.5%) to 43.172%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/common/api.js 26 27 96.3%
src/main/moonpay/moonpay-api.js 193 198 97.47%
Totals Coverage Status
Change from base Build 18641: 1.5%
Covered Lines: 3701
Relevant Lines: 7895
💛 - Coveralls

@sk91 sk91 removed the Work-In-Progress This PR is incomplete. Do not merge. label Dec 21, 2020
@sk91 sk91 mentioned this pull request Dec 21, 2020
Merged
andregoncalves
andregoncalves approved these changes Dec 22, 2020
View reviewed changes
Copy link
Collaborator

@andregoncalves andregoncalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sk91 sk91 merged commit f35b34f into dev Dec 22, 2020
@sk91 sk91 deleted the 2531-moonpat-sdk branch December 22, 2020 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andregoncalves andregoncalves andregoncalves approved these changes

@maycon-mello maycon-mello Awaiting requested review from maycon-mello

Assignees

@sk91 sk91

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sk91 @coveralls @andregoncalves