Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2512 moonpay auth #2533

Merged
merged 12 commits into from
Dec 29, 2020
Merged

2512 moonpay auth #2533

merged 12 commits into from
Dec 29, 2020

Conversation

sk91
Copy link
Contributor

@sk91 sk91 commented Dec 21, 2020 •
edited
Loading

Screenshot 2020-12-26 at 00 21 41

Screenshot 2020-12-26 at 00 21 50

Screenshot 2020-12-26 at 00 21 57

Screenshot 2020-12-26 at 00 22 08

Screenshot 2020-12-26 at 00 29 11

@sk91 sk91 added the Work-In-Progress This PR is incomplete. Do not merge. label Dec 21, 2020
@sk91 sk91 self-assigned this Dec 21, 2020
@sk91 sk91 removed the Work-In-Progress This PR is incomplete. Do not merge. label Dec 25, 2020
@sk91 sk91 requested a review from andregoncalves December 25, 2020 22:27
andregoncalves
andregoncalves approved these changes Dec 28, 2020
View reviewed changes
Copy link
Collaborator

@andregoncalves andregoncalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (I probably missed something, I still have to dive deeper into the flow logic)

@sk91 sk91 merged commit d75c445 into dev Dec 29, 2020
@sk91 sk91 deleted the 2512-moonpay-auth branch December 29, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andregoncalves andregoncalves andregoncalves approved these changes

Assignees

@sk91 sk91

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sk91 @andregoncalves