-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🐛 Bug]: helm charts try to execute /opt/selenium/nodeProbe.sh #2141
Comments
@bschreder, thank you for creating this issue. We will troubleshoot it as soon as we can. Info for maintainersTriage this issue by using labels.
If information is missing, add a helpful comment and then
If the issue is a question, add the
If the issue is valid but there is no time to troubleshoot it, consider adding the
If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C),
add the applicable
After troubleshooting the issue, please add the Thank you! |
It looks like you are using an umbrella chart where the selenium-grid is the chart dependency. With the default value using Ideally, script will be mounted via ConfigMap, so no need further steps to copy, just an issue with chart template |
…brella charts Fix issue SeleniumHQ#2141 Signed-off-by: Viet Nguyen Duc <[email protected]>
…brella charts Fix issue SeleniumHQ#2141 Signed-off-by: Viet Nguyen Duc <[email protected]>
…brella charts Fix issue SeleniumHQ#2141 Signed-off-by: Viet Nguyen Duc <[email protected]>
…brella charts Fix issue SeleniumHQ#2141 Signed-off-by: Viet Nguyen Duc <[email protected]>
@bschreder, chart |
@VietND96 still same issue with |
May I know in your chart, all default are using, or there is overriding, e.g different node config map is set? |
An alternative config allows switch back to the default startup probe method |
One help, can you dry run |
Ok, I'm able to reproduce with a dummy chart and import selenium-grid as chart dependency. The scripts in |
|
@VietND96, Thanks for making all these recent changes. I know our QA team is looking forward to adding these new capabilities to our test runs. Our setup makes small changes to the selenium-grid. The main change is we use our own ingress controller (disable selenium-grid ingress), override child chart values and add annotations for affinity. I also noticed that the .Release.Name defaults to 'release-name' since I didn't set it in the helm template command. This value is correctly provided to the subcharts. I ran the template command before setting the defaultNodeStartupProbe to httpGet. For the files below, I removed our ingress controller and used the selenium-grid ingress. I also removed our affinity and tolerance specifications. I hope this makes it easier to discuss. template command:
|
I see the scripts in the config directory extracted from the .tgz file. I see line 27+ of node-configmap.yaml that loops over extraScripts, but I'm not seeing the In the node-deployment file above, I see the volumeMounts and volumes specified. I think this is good. I hope this helps. |
I tried to read few docs and issues report to Helm. Looks like |
Fixed SeleniumHQ#2141 When it is imported as a sub-chart in another chart, files could not load Signed-off-by: Viet Nguyen Duc <[email protected]>
Fixed SeleniumHQ#2141 When it is imported as a sub-chart in another chart, files could not load Signed-off-by: Viet Nguyen Duc <[email protected]>
Chart |
@VietND96 thanks for the fix. |
I still see the same error when using 0.28.2 and 0.28.3 |
@CameronWard301, may I know your values used? do you override nodeConfigMap with your own? Since we have a template test to confirm it works |
Hi, Getting below error when installed 4.18.1-20240224 Version on my Kubernetes Cluster (v1.23.1). chrome-node, edge-node and firefox-node not turning to ready status. Showing (0/1) Error Message
Getting below error When I tried
Can anyone help. Am I missing anything here? |
@kanthasamyraja, the idea of script is getting Grid status via |
Thanks @VietND96 for your response. No response. Waiting..
Pod status
Logs
|
No I didn't override any values or config maps, I simply added it as a repository to my chart.yml and did helm upgrade |
@kanthasamyraja, |
@CameronWard301, yes, so you are facing the same issue discussed above? The startup probe not return the correct value caused the pod ready 0/1 ? |
@VietND96 Yes same issue with the startup probe |
I had the same issue on 0.28.3, I fixed it by setting the
|
Hi @VietND96 SE_NODE_GRID_URL in the node is using the default rendered by chart, right?
Command Output
|
@kanthasamyraja, thank you for your input, I am investigating this case and give a possible fix soon |
…fecycle Fixed SeleniumHQ#2141 Fixed SeleniumHQ#2157 Signed-off-by: Viet Nguyen Duc <[email protected]>
@kanthasamyraja, and all. If you are having a sandbox env for trial, can you check the Updated: chart 0.28.4 is out |
Hi @VietND96 Working.
k describe po selenium-grid-selenium-edge-node-776bdd8f59-69gzt
|
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What happened?
helm selenium-grid 0.28 release only
PR #2139 assumes that a script
{{ $.Values.nodeConfigMap.extraScriptsDirectory }}/nodeProbe.sh
that resolves to
/opt/selenium/nodeProbe.sh
This file doesn't exist in the node-chrome:latest image ( imageTag: 4.18.0-20240220 )
I checked:
Neither of these avenues were successful.
I also noticed that the Edge and Firefox browsers had the same issue.
Work around: use selenium-grid version 0.27.0
Command used to start Selenium Grid with Docker (or Kubernetes)
Relevant log output
Operating System
Azure Kubernetes Service (AKS)
Docker Selenium version (image tag)
4.18.0-20240220
Selenium Grid chart version (chart version)
0.28.0
The text was updated successfully, but these errors were encountered: