-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🐛 Bug]: grid url in node-chrome logs contains credentials #2157
Comments
@amardeep2006, thank you for creating this issue. We will troubleshoot it as soon as we can. Info for maintainersTriage this issue by using labels.
If information is missing, add a helpful comment and then
If the issue is a question, add the
If the issue is valid but there is no time to troubleshoot it, consider adding the
If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C),
add the applicable
After troubleshooting the issue, please add the Thank you! |
I can send a PR if we just need to delete the lines generating logs from shell script. |
The logs belong to the startup probe, in another fix I already refactored it. |
I can not appreciate your work enough. Blazing fast !!!! |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What happened?
Grid is deployed on kubernetes.
I was looking at node-chrome logs and I see that at least 4 times per pod life cycle it prints grid-url in logs.
Issue : If your grid is protected by basic auth then it leaks credentials in logs. This is a potential security issue.
Command used to start Selenium Grid with Docker (or Kubernetes)
Relevant log output
Operating System
Kubernetes
Docker Selenium version (image tag)
4.18.1
Selenium Grid chart version (chart version)
0.28.1
The text was updated successfully, but these errors were encountered: