Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 Bug]: grid url in node-chrome logs contains credentials #2157

Closed
amardeep2006 opened this issue Mar 2, 2024 · 5 comments
Closed

[🐛 Bug]: grid url in node-chrome logs contains credentials #2157

amardeep2006 opened this issue Mar 2, 2024 · 5 comments

Comments

@amardeep2006
Copy link
Contributor

What happened?

Grid is deployed on kubernetes.
I was looking at node-chrome logs and I see that at least 4 times per pod life cycle it prints grid-url in logs.
Issue : If your grid is protected by basic auth then it leaks credentials in logs. This is a potential security issue.

image

Command used to start Selenium Grid with Docker (or Kubernetes)

Helm chart 0.28.1

Relevant log output

Pls see Attached screen shot

Operating System

Kubernetes

Docker Selenium version (image tag)

4.18.1

Selenium Grid chart version (chart version)

0.28.1

Copy link

github-actions bot commented Mar 2, 2024

@amardeep2006, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@amardeep2006
Copy link
Contributor Author

I can send a PR if we just need to delete the lines generating logs from shell script.

@VietND96
Copy link
Member

VietND96 commented Mar 4, 2024

The logs belong to the startup probe, in another fix I already refactored it.
Also, another setting added to allow enable/disable stdout of probes or preStop scripts global.seleniumGrid.stdoutProbeLog

@amardeep2006
Copy link
Contributor Author

I can not appreciate your work enough. Blazing fast !!!!
I have seen very few engineers like you !!! Awesome work @VietND96

Copy link

github-actions bot commented Apr 4, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants