Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out _make_run_grpc_server #4351

Merged
merged 4 commits into from
Nov 15, 2022

Conversation

zyxue
Copy link
Contributor

@zyxue zyxue commented Sep 29, 2022

continuation of #4268 to make main more modular and readable.

@seldondev
Copy link
Collaborator

Hi @zyxue. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@axsaucedo
Copy link
Contributor

Nice one - thank you @zyxue

@axsaucedo
Copy link
Contributor

/test integration

1 similar comment
@axsaucedo
Copy link
Contributor

/test integration

@zyxue
Copy link
Contributor Author

zyxue commented Oct 13, 2022

@axsaucedo , am I able to see the failed test?

@axsaucedo
Copy link
Contributor

@zyxue it seems it was a flaky test, we'll re-run
/test integration

@axsaucedo
Copy link
Contributor

Thank you once again for the contribution @zyxue !
/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo axsaucedo merged commit 2c861a9 into SeldonIO:master Nov 15, 2022
@zyxue zyxue deleted the factor-out-_make_run_grpc_server branch November 15, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants