factored out make_rest_server_debug/prod

[zyxue]

The idea is to factor parts out of main to make it more modular and readable.

If this PR works out. will factor out _make_rest_metrics_server and _make_grpc_server next.

Running make test locally seems flaky, even on master.

[seldondev]

Hi @zyxue. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

[axsaucedo]

Thank you for the contribution @zyxue - changes look reasonable, I just added a small change to remove anonymous args, but overall should make it more readable, thanks.

[axsaucedo]

In regards to the comment of flaky make test, we've been aware of the flakiness for a while - if you get a chacne to have a look that would actually also be of huge help for the project

/test integration

[axsaucedo]

Integration tests pass, can merge once the updates above are carried out

[zyxue]

@axsaucedo , mind take another look, please?

[axsaucedo]

Thank you very much for the contribution @zyxue

/approve

[seldondev]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [axsaucedo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment