Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect envSecretRefName coming from helm values #4089

Merged
merged 4 commits into from
May 11, 2022
Merged

respect envSecretRefName coming from helm values #4089

merged 4 commits into from
May 11, 2022

Conversation

RafalSkolasinski
Copy link
Contributor

@RafalSkolasinski RafalSkolasinski commented May 10, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Closes #3640

Special notes for your reviewer:

In addition did some cleanup on Ansible in Core.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@RafalSkolasinski RafalSkolasinski marked this pull request as draft May 10, 2022 14:59
@RafalSkolasinski RafalSkolasinski marked this pull request as ready for review May 10, 2022 15:16
@RafalSkolasinski RafalSkolasinski changed the title Respect respect envSecretRefName coming from helm values May 10, 2022
@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski
Copy link
Contributor Author

All seems to work fine, I will look into adding some unit tests.

However, is it okay to use secret from

predictiveUnit:
  defaultEnvSecretRefName: < secret here >

for explainers? Internally we refer to nodes of inference graph as predictive units.

Personally, I think this is okay. I do not see need to introduce another field in helm values for explainer secrets.

@RafalSkolasinski
Copy link
Contributor Author

integration tests passed
image

@axsaucedo
Copy link
Contributor

It seems to have quite a few ansible and prometheus changes, is this intended?

@RafalSkolasinski
Copy link
Contributor Author

Yes, the ansible in here needed a cleanup for quite some time. And on prometheus it is just a change of namespace in which example/docs installs it.

@axsaucedo
Copy link
Contributor

Ok - the pr looks good on the explainers envSecretRef, i added a comment on the prometheus, mainly on renaming the namespace

@axsaucedo
Copy link
Contributor

Looks good
/approve

@axsaucedo axsaucedo self-requested a review May 11, 2022 14:23
@axsaucedo axsaucedo merged commit 83cfb98 into SeldonIO:master May 11, 2022
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explainers do not respect defaultEnvSecretRefName helm value
3 participants