-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
respect envSecretRefName coming from helm values #4089
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
/test integration |
All seems to work fine, I will look into adding some unit tests. However, is it okay to use secret from
for explainers? Internally we refer to nodes of inference graph as predictive units. Personally, I think this is okay. I do not see need to introduce another field in helm values for explainer secrets. |
It seems to have quite a few ansible and prometheus changes, is this intended? |
Yes, the ansible in here needed a cleanup for quite some time. And on prometheus it is just a change of namespace in which example/docs installs it. |
Ok - the pr looks good on the explainers envSecretRef, i added a comment on the prometheus, mainly on renaming the namespace |
Looks good |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Closes #3640
Special notes for your reviewer:
In addition did some cleanup on Ansible in Core.