Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python request logger example component deprication and removal #4016

Merged
merged 7 commits into from
Apr 7, 2022
Merged

Python request logger example component deprication and removal #4016

merged 7 commits into from
Apr 7, 2022

Conversation

axsaucedo
Copy link
Contributor

@axsaucedo axsaucedo commented Apr 1, 2022 •
edited
Loading

Fixes #4013

  • Removal of Python request logger example component
  • Removal of documentation resources referncing python logger
  • Removal of e2e tests including request logger component
  • Outlining in upgrading documentation

The extra example using message dumper or fluentd will be tackled via #4033

@axsaucedo axsaucedo changed the title WIP: Python request logger example component deprication and removal Python request logger example component deprication and removal Apr 5, 2022
@SachinVarghese
Copy link
Contributor

LGTM

@axsaucedo
Copy link
Contributor Author

Thanks @SachinVarghese - any required changes before merge @michaelcheah?

michaelcheah
michaelcheah approved these changes Apr 7, 2022
View reviewed changes
doc/source/reference/upgrading.md Outdated Show resolved Hide resolved
@axsaucedo
Copy link
Contributor Author

Nice one - thanks @SachinVarghese @michaelcheah, merging
/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo, michaelcheah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo, michaelcheah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo axsaucedo merged commit 6a6fa4c into SeldonIO:master Apr 7, 2022
@axsaucedo axsaucedo mentioned this pull request Apr 7, 2022
Merged
@ysk24ok ysk24ok mentioned this pull request Apr 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelcheah michaelcheah michaelcheah approved these changes

@ukclivecox ukclivecox Awaiting requested review from ukclivecox

@SachinVarghese SachinVarghese Awaiting requested review from SachinVarghese

Assignees
No one assigned
Labels
approved size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removal & depreciation of request logger component
4 participants
@axsaucedo @SachinVarghese @seldondev @michaelcheah